Which one is easier to develop and work with (which saves the most time)? Which one would you go for? The name of the API represents its true purpose in this case by the way, createOrUpdate creates or updates the passed in meeting and create just creates the meeting. I will be the only one working on this project for now, although obviously, I would like others to work on it with me eventually.

  • Joe@kbin.social
    link
    fedilink
    arrow-up
    2
    ·
    1 year ago

    I would have 2 functions: createMeeting and updateMeeting

    No point having one function do two different things, especially if one of them isn’t even hinted at by the function name

  • fabian@programming.dev
    link
    fedilink
    English
    arrow-up
    1
    ·
    edit-2
    1 year ago

    Well, it makes the client-side calls a bit simpler if you don’t distinguish create and update via POST/PUT, so at the server-side you have a single POST endpoint which does the upsert, but there it would be sensible to dispatch to separate methods for insert and update each.

  • macgregor@lemmy.world
    link
    fedilink
    English
    arrow-up
    1
    ·
    1 year ago

    Many databases or database clients have an “upsert” operation which is exactly this. Create or update this entity. If the DB supports it you can save an explicit lookup giving minor performance and code cleanliness improvements in application but might shift that performance cost to the DB (had to rollback a prod change not too long ago because someone switched to a PG upsert and it caused average CPU to rise, haven’t gotten a chance to investigate why yet, something about indexes probably).

    Anyway, I tend to start with just explicit create and update methods and add an “upsert” abstraction if I find myself sprinkling lots of checks around making code messy. So I would go for “createOrUpdateFoo” in that case.

  • TheButtonJustSpins@infosec.pub
    link
    fedilink
    English
    arrow-up
    1
    ·
    1 year ago

    Is there any reason that the caller wouldn’t know if the meeting they’re holding has been created or not? I’d keep it simple by keeping them separate unless there’s a compelling reason to meld them.